Revert "chore: exclude cli-plugins/copilot from pnpm workspace (#5345)" - #5346
Merged
Conversation
This reverts commit 48345f0.
🦋 Changeset detectedLatest commit: ae00d48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
Bot
added
the
📚 documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5345.
Why is this change needed?
#5345 excluded
packages/cli-plugins/copilotfrom the pnpm workspace to shrink the shared pnpm-store cache by ~400MB. Follow-up investigation showed the actual CI cost isn't the cache's on-disk size (removing the plugin only saved ~150MB, not the ~400-500MB estimated) — it's the time spent transferring the cache from GitHub's cache storage to our self-hosted runner. Excluding the package from the workspace doesn't address that, so it's not worth the added maintenance burden of an out-of-workspace package (separate install/build/patch process, no Changesets versioning).We'll revisit the actual cache-transfer cost with infra before making workspace-structure changes for this reason again.
What is the new behavior?
Straight revert of #5345 —
packages/cli-plugins/copilotis back in the pnpm workspace and root TypeScript project references, usingworkspace:^for@equinor/fusion-framework-cli, with its patch and changesets restored.Does this PR introduce a breaking change?
No — restores prior, already-shipped behavior.